RPE::evaluate_and_process(): pack only if needed #15163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
requested changes
May 1, 2023
Comment on lines
332
to
345
| template <typename T> | ||
| std::enable_if_t<Utilities::MPI::is_mpi_type<T> == true, void> | ||
| pack_and_isend(T * data, | ||
| const unsigned int size, | ||
| const unsigned int rank, | ||
| const unsigned int tag, | ||
| const MPI_Comm comm, | ||
| std::vector<std::vector<char>> &buffers, | ||
| std::vector<MPI_Request> & requests) | ||
| { | ||
| requests.emplace_back(MPI_Request()); | ||
|
|
||
| buffers.emplace_back( | ||
| Utilities::pack(std::vector<T>(data, data + size), false)); |
There was a problem hiding this comment.
You have this the wrong way around: This is the function with Utilities::MPI::is_mpi_type<T> == true for which you specifically don't have to pack, whereas for the function above where you don't pack you actually do have to pack.
peterrum
force-pushed
the
evaluate_and_process_refactor_no_copy
branch
3 times, most recently
from
8993018
to
70f9e5b
Compare
13 tasks
peterrum
force-pushed
the
evaluate_and_process_refactor_no_copy
branch
from
70f9e5b
to
0e74f25
Compare
|
@peterrum How do we proceed with this PR? |
Shift around More ArrayView Specialize code for tensors Allow to specify components Also for evaluate_and_process() Update Reduce number of sweeps
peterrum
force-pushed
the
evaluate_and_process_refactor_no_copy
branch
from
f642dd1
to
bc18550
Compare
|
I tried the new code with the additional restructuring and I am very happy about the performance gain we can get (together with #16896, #16895, I see an improvement of around a factor of 2 in the non-nested multigrid algorithm on a server processor). I will look into the code once you think it is complete enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #15156