Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce distributed_compute_intersection_locations #15166

Conversation

jh66637
Copy link
Contributor

@jh66637 jh66637 commented May 2, 2023

Belongs to #14338.

Needs #15165 to be merged before, (thus the pipeline is expected to fail)

This PR introduces the function which collects intersections (using CGAL) on multiple MPI ranks. As for #15165 I will add tests once we agree on this function.

@fdrmrc @peterrum

@jh66637 jh66637 force-pushed the distributed_compute_intersection_locations branch from ab6877b to 9b282ca Compare May 2, 2023 14:01
Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jh66637 This looks very well already! This is a very nice feature! Thanks for working on this!

May I ask you to merge this PR and #15165. They are closely related so no need to deal with them separately.

@fdrmrc Once @jh66637 integrated the changes and the PR has been rebased on #15154 may I ask you to take a look at the PR as well, since you are also considering to use this infrastructure in the future.

include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
include/deal.II/grid/grid_tools.h Show resolved Hide resolved
@jh66637
Copy link
Contributor Author

jh66637 commented May 7, 2023

May I ask you to merge this PR and #15165. They are closely related so no need to deal with them separately.

Sure I can merge them, :) I will firstly address your review and afterward add the other PR.

@jh66637
Copy link
Contributor Author

jh66637 commented May 18, 2023

I fused the PRs as requested. One comment is currently not addressed, but I copied it over. Therefore, I am closing this PR :)

@jh66637 jh66637 closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants