Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid missing symbols and use constexpr functions instead #15181

Merged
merged 1 commit into from May 5, 2023

Conversation

kronbichler
Copy link
Member

Since #15137 has been merged, we have some linker errors, e.g. this one https://cdash.dealii.org/test/50357345 in the build https://cdash.dealii.org/viewTest.php?onlyfailed&buildid=4614 (look at the ones with point_evaluation). Technically, we would need to instantiate the static constexpr member variables. Since I do not want to do this for all types of VectorizedArray and Number we might have, my preference is to instead have constexpr functions similar to VectorizedArray::size(), which should avoid the problem altogether. Opinions?

FYI @bergbauer

@kronbichler kronbichler changed the title Avoid missing symbols by constexpr functions Avoid missing symbols and use constexpr functions instead May 5, 2023
Copy link
Contributor

@bergbauer bergbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we now use width() in the Asserts in VectorizedArrayTrait<>::get()? I could not use it because of linker errors before.

@kronbichler
Copy link
Member Author

Let's see if this works on the tester, otherwise I will look for some other solution.

@bangerth
Copy link
Member

bangerth commented May 5, 2023

Do we care about the lack of backward compatibility?

@peterrum
Copy link
Member

peterrum commented May 5, 2023

Do we care about the lack of backward compatibility?\

This is internal functionality.

@bangerth
Copy link
Member

bangerth commented May 5, 2023

I believe that the failing test is unrelated.

@bangerth bangerth merged commit a091f25 into dealii:master May 5, 2023
13 of 14 checks passed
@kronbichler kronbichler deleted the fix_missing_symbol branch August 10, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants