Weight kernel for multigrid: Simplify aliasing analysis for compiler #15185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
approved these changes
May 8, 2023
tamiko
approved these changes
May 8, 2023
peterrum
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change simplifies the analysis of the compiler whether two arrays overlap (alias): We know that the weight is constant throughout the loop, so move them to a separate variable. This helps the additive Schwarz-type smoothers of https://github.com/peterrum/dealii-dd-and-schwarz as well as the multigrid transfer. This is a very minor change for the case the L1 access is the limiting factor.