Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overhead from AlignedVector in FEFaceNormalEvaluationImpl #15193

Merged
merged 1 commit into from May 13, 2023
Merged

Remove overhead from AlignedVector in FEFaceNormalEvaluationImpl #15193

merged 1 commit into from May 13, 2023

Conversation

bergbauer
Copy link
Contributor

We observed overhead from the destructor of AlignedVector in FEFaceNormalEvaluationImpl.

Circumvent this by using raw pointers instead.

@kronbichler

@bergbauer bergbauer force-pushed the reduce_overhead_fe_face_normal_eval branch from b650f18 to 6d2effb Compare May 11, 2023 14:56
@peterrum
Copy link
Member

/rebuild

kronbichler
kronbichler approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a step in the right direction. We should look over the arguments also for other functions, but we can postpone that.

@kronbichler kronbichler merged commit 457dd62 into dealii:master May 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kronbichler kronbichler kronbichler approved these changes

@peterrum peterrum peterrum approved these changes

Assignees
No one assigned
Labels
Matrix-free ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bergbauer @peterrum @kronbichler