Adds create_with_same_size function #15204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to change the pattern ``` VectorType v; v.reinit(other); ``` to ``` auto v = VectorType::create_with_same_size(other); ``` which does not require VectorType to be default constructible
This changes some functions to return new vectors, instead of using output parameters. In these cases, the output parameter were created directly before, so there should be no difference.
tamiko
requested changes
Jul 4, 2023
There was a problem hiding this comment.
I strongly oppose this change of creating a static create_with_same_size function that acts as a factory function for creating a vector.
We have settled on our somewhat idiomatic, but nevertheless uniform set of default constructors, copy/assignment, and reinit() functions. I do not think that we should change this interface lightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a static function
create_with_same_sizeto (hopefully) all vector types. This function can be uses instead of the patternto create a new vector that has the same size (and possible other properties) as the input vector. In most places
create_with_same_sizeis actually implemented using the above pattern. But this function can be used for non-default-constructible vectors (such as the ones introduced in #15190), while the above pattern would not work.The pattern above is replaced where I could find it. Also, some functions are changed a bit more to be able to use the new interface.