Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix step-77: zero out residual before assembly #15210

Merged
merged 1 commit into from May 13, 2023

Conversation

sebproell
Copy link
Contributor

This patch resolves the problem in #15194.

@bangerth @luca-heltai N_Vector interfaces are correct after all :)

@peterrum
Copy link
Member

/rebuild

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oy vey! Nice find. The second bug of this kind found in this function of step-77 (#14531).

Would you mind making the same change also in tests/trilinos/step-77-nox.cc?

@bangerth bangerth merged commit 98cef4b into dealii:master May 13, 2023
14 checks passed
@bangerth
Copy link
Member

Oh, and if you do the other change, please also add a changelog entry for the fix. This is a visible change, you should get credit for it!

@sebproell sebproell deleted the step77-zero-residual branch May 14, 2023 13:45
@sebproell sebproell mentioned this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants