New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Use import targets in FindDEAL_II_BOOST.cmake #15254
base: master
Are you sure you want to change the base?
Conversation
@masterleinad This is the goal 😄 (this here works with all pull requests merged and with CMake 3.19 onwards). |
0ae40ec
to
ce5d01a
Compare
ce5d01a
to
842ae9d
Compare
I'm surprised that we are suddenly seeing |
@masterleinad This probably comes from the fact that this particular So with a full Boost installation with version 1.74 onwards everything configures as expected. With version 1.71 we see a failure with the serialization check. With a custom-installed version 1.74 CMake is unable to find some modules but the find module emits these targets nevertheless:
|
Update: oops the boost serialization test does not work at all with import targets. We simply don't see it for boost 1.74 onwards because we skip this expensive check in this case. |
Depends on #15252 #15253