Use Kokkos CMake targets #15283
Merged
Use Kokkos CMake targets #15283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
cmake_kokkos_targets
branch
from
fe99c67
to
09e75bb
Compare
|
/rebuild |
Rombur
approved these changes
Jun 7, 2023
tamiko
approved these changes
Jun 7, 2023
tamiko
reviewed
Jun 7, 2023
| CXX_FLAGS OPTIONAL KOKKOS_COMPILE_FLAGS | ||
| LINKER_FLAGS OPTIONAL KOKKOS_EXTRA_LD_FLAGS | ||
| CLEAR KOKKOS_DIR KOKKOS_CORE_LIBRARY KOKKOS_CONTAINERS_LIBRARY | ||
| TARGETS REQUIRED _target |
There was a problem hiding this comment.
So much better.
We'll have to discuss how to get rid of the "_target" variable for the process_feature macro. But that's probably a small project for the workshop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.