New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test icpx instead of icpc #15308
Test icpx instead of icpc #15308
Conversation
source/base/qprojector.cc
Outdated
const auto temp = | ||
ReferenceCells::Line.permute_according_orientation(vertices, | ||
orientation); | ||
ArrayView<const Point<2>> vertices(face.first.begin(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
class DEAL_II_DEPRECATED GridReordering | ||
class GridReordering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?? Do we use this class anywhere so that we want to un-deprecate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, forgot to hit send:
All its members are deprecated so this only avoids deprecation warnings when defining those in the *.cc
file.
/rebuild |
The windows tester doesn't like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSVC looks happy now :)
Fixes #15301. We could of course add this as an extra build.