Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test icpx instead of icpc #15308

Merged
merged 4 commits into from Jun 6, 2023
Merged

Test icpx instead of icpc #15308

merged 4 commits into from Jun 6, 2023

Conversation

masterleinad
Copy link
Member

Fixes #15301. We could of course add this as an extra build.

const auto temp =
ReferenceCells::Line.permute_according_orientation(vertices,
orientation);
ArrayView<const Point<2>> vertices(face.first.begin(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

class DEAL_II_DEPRECATED GridReordering
class GridReordering
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? Do we use this class anywhere so that we want to un-deprecate it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot to hit send:
All its members are deprecated so this only avoids deprecation warnings when defining those in the *.cc file.

@masterleinad
Copy link
Member Author

/rebuild

@marcfehling
Copy link
Member

The windows tester doesn't like this:

D:\a\dealii\dealii\source\base\qprojector.cc(772,43): error C2664: 'dealii::ArrayView<const dealii::Point<2,Number>,dealii::MemorySpace::Host>::ArrayView(const dealii::Point<2,Number> *,const size_t)': cannot convert argument 1 from 'std::_Array_const_iterator<_Ty,2>' to 'const dealii::Point<2,Number> *' [D:\a\dealii\dealii\build\source\base\object_base_debug.vcxproj]
          with
          [
              Number=double
          ]
          and
          [
              _Ty=dealii::Point<2,double>
          ]
          and
          [
              Number=double
          ]
D:\a\dealii\dealii\source\base\qprojector.cc(772,60): message : No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called [D:\a\dealii\dealii\build\source\base\object_base_debug.vcxproj]
D:\a\dealii\dealii\include\deal.II/base/array_view.h(128,3): message : see declaration of 'dealii::ArrayView<const dealii::Point<2,Number>,dealii::MemorySpace::Host>::ArrayView' [D:\a\dealii\dealii\build\source\base\object_base_debug.vcxproj]
          with
          [
              Number=double
          ]
D:\a\dealii\dealii\source\base\qprojector.cc(805): message : see reference to function template instantiation 'std::vector<dealii::Point<2,Number>,std::allocator<dealii::Point<2,Number>>> dealii::QProjector<2>::project_to_all_faces::<lambda_0c83d88963be66288dded01df112f8f9>::operator ()<_Ty,unsigned int>(const _Ty &,const unsigned int &) const' being compiled [D:\a\dealii\dealii\build\source\base\object_base_debug.vcxproj]
          with
          [
              Number=double,
              _Ty=std::pair<std::array<dealii::Point<2,double>,2>,double>
          ]
  fe_dgp_monomial.cc
D:\a\dealii\dealii\source\base\qprojector.cc(804): message : see reference to function template instantiation 'std::vector<dealii::Point<2,Number>,std::allocator<dealii::Point<2,Number>>> dealii::QProjector<2>::project_to_all_faces::<lambda_0c83d88963be66288dded01df112f8f9>::operator ()<_Ty,unsigned int>(const _Ty &,const unsigned int &) const' being compiled [D:\a\dealii\dealii\build\source\base\object_base_debug.vcxproj]
          with
          [
              Number=double,
              _Ty=std::pair<std::array<dealii::Point<2,double>,2>,double>
          ]

Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC looks happy now :)

@marcfehling marcfehling merged commit 1a7fb37 into dealii:master Jun 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-actions: Switch to Intel ICX compiler.
3 participants