Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use numbers::is_finite whenever we compare with infinity. #15314

Merged
merged 1 commit into from Jun 6, 2023
Merged

Use numbers::is_finite whenever we compare with infinity. #15314

merged 1 commit into from Jun 6, 2023

Conversation

marcfehling
Copy link
Member

Part of #15301.

The patch replaces comparisons with infinity by using numbers::is_finite. This gets rid of the warnings of the icpx compiler, and I think the patch also makes the code more easily readable.

@marcfehling marcfehling mentioned this pull request Jun 6, 2023
Closed
@marcfehling marcfehling added this to the Release 9.5 milestone Jun 6, 2023
@marcfehling
Copy link
Member Author

matrix_free/point_evaluation_25.debug fails because I didn't rebase.

@bangerth bangerth merged commit 9fcc068 into dealii:master Jun 6, 2023
12 of 14 checks passed
@marcfehling marcfehling deleted the isfinite branch June 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@bangerth bangerth bangerth approved these changes

Assignees
No one assigned
Labels
ready to test Reviewed and ready to merge
Projects
None yet
Milestone
Release 9.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcfehling @masterleinad @bangerth