github-actions: Do not treat tautological-constant-compare as error.
#15327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The question is whether we still get correct code? |
|
In my opinion, we shouldn't try to promise (and thus test) correctness for |
|
To be clear, I'm ok with enabling this flag for the CI check. But it should not be a default flag we use for this compiler. |
bangerth
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15301.
Instead of disabling finite math for the IntelLLVM build, I propose to no longer treat the warning associated with the
isnancomparison as an error. They will still be displayed as warnings, but the build completes. This only affects the CI check, not the general way we build the library with IntelLLVM.This way we can catch other issues related to finite math mode, which is the default for the IntelLLVM compiler.
@masterleinad -- What do you think?