improve name and documentation #15369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Jun 16, 2023
bangerth
requested changes
Jun 16, 2023
include/deal.II/grid/grid_tools.h
Outdated
| @@ -1361,7 +1361,8 @@ namespace GridTools | |||
| std::vector<unsigned int> recv_ptrs; | |||
|
|
|||
| /** | |||
| * Distribute quadrature points on found intersections and construct | |||
| * Distribute structdim*n_points_1D quadrature points on found | |||
There was a problem hiding this comment.
Is this right? Shouldn't it be n_points_1d ^ structdim?
There was a problem hiding this comment.
Thank you for spotting, this is what I wanted to write. I checked the Code and QGaussSimplex() does not always have n_points_1d ^ structdim points. So I rephrased the documentation.
bangerth
approved these changes
Jun 16, 2023
|
/rebuild |
kronbichler
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
distributes
structdim*n_quadrature_pointsquadrature points, and therefore the name can be easily misunderstood.