Wait for communication to finish. #15372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Jun 16, 2023
| @@ -3665,6 +3665,11 @@ namespace GridTools | |||
| AssertThrowMPI(ierr); | |||
| } | |||
|
|
|||
| // At this point, wait for all of the isend operations to finish: | |||
There was a problem hiding this comment.
You could move this Waitall to the end of the function, which potentially could improve performance. Or am I wrong?
There was a problem hiding this comment.
I did think of this, but couldn't quite convince myself that that was right -- and then decided that for purposes of a fix for an actual problem, this is good enough. The function is improveworthy anyway for a variety of reasons, and that's on my list for post-release. I think as a bug fix, this is all I propose.
tjhei
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #14127 points out, we do some
isendsin a function but never wait for these operations to actually finish. This creates a race condition. This patch adds the requisiteMPI_Waitoperations.Fixes #14127.