Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixFree: Only set up the inner faces when so requested #15381

Merged
merged 1 commit into from Jul 1, 2023

Conversation

kronbichler
Copy link
Member

MatrixFree::reinit() would previously aggressively set up both interior faces and boundary faces also when only the boundary faces were requested (e.g., when using continuous elements with some Robin-type boundary conditions, one does not want to set up all interior faces which require more expensive data exchange routines). This is now fixed and the behavior is as documented:

* @note In order to be able to perform a `face_operation`
* in the MatrixFree::loop(), this field must be set to a value different
* from UpdateFlags::update_default.
*/
UpdateFlags mapping_update_flags_inner_faces;

This PR creates a backward compatibility problem, in the sense that some codes that relied on this (undocumented) feature will now not perform face integrals. To be done after we branched for the 9.5 release.

@tamiko tamiko merged commit bd60e7b into dealii:master Jul 1, 2023
14 checks passed
@kronbichler kronbichler deleted the mf_create_inner_faces branch August 10, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants