New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release preparation: Run codespell. #15386
Conversation
We now print the correct copyright year.
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
How hard would you think it is to hook whatever script you ran into the CI?
These spellcheckers are not a good fit for the CI since we use a lot of non-English words. Some examples:
We'd have to maintain a pretty substantial additional word list to make these tools run cleanly. I think its wiser to just run them at release time and manually inspect the output. |
Ah, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. It is always interesting to see how many typos are slipping through, and it is great to have this step once per year.
substract_and_norm( | ||
subtract_and_norm( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
I ran codespell, our own detect double-word typos script, and typos.