Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testsuite: metis/metis_*: only run tests, do not compare output #15389

Merged
merged 1 commit into from Jun 20, 2023
Merged

Testsuite: metis/metis_*: only run tests, do not compare output #15389

merged 1 commit into from Jun 20, 2023

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 20, 2023

We currently carry 5 output variants per test and I would have to add another 2 output variants for all tests to pass on the regression tester.

I think it is time that we acknowledge that metis output is not stable.

Instead let us simply check that the tests compile and run successfully without throwing an error.

In reference to #15383

@tamiko
Test metis/metis_*: only run tests, do not compare output
30358c0 
We currently carry 5 output variants per test and I would have to add
another 2 output variants for all tests to pass on the regression
tester.

I think it is time that we acknowledge that metis output is not stable.

Instead let us simply check that the tests compile and run successfully
without throwing an error.
@tamiko tamiko changed the title Test metis/metis_*: only run tests, do not compare output Testsuite: metis/metis_*: only run tests, do not compare output Jun 20, 2023
@tamiko tamiko added this to the Release 9.5 milestone Jun 20, 2023
drwells
drwells approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@drwells drwells left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are almost always out-of-date since metis has such unstable output.

+0 -159,770

Nice!

kronbichler
kronbichler approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree as well, it makes little sense to print these numbers, and I would say it is up to METIS with its own tests to ensure reasonable partitions.

@tamiko tamiko merged commit 5ce6a12 into dealii:master Jun 20, 2023
11 of 14 checks passed
@tamiko tamiko deleted the fix_metis_tests branch July 7, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@drwells drwells drwells approved these changes

@kronbichler kronbichler kronbichler approved these changes

Assignees
No one assigned
Labels
Reviewed and ready to merge Tests
Projects
None yet
Milestone
Release 9.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tamiko @masterleinad @drwells @kronbichler