Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArborX tests for Trilinos 14/Kokkos 4 #15391

Merged
merged 1 commit into from Jun 20, 2023
Merged

Fix ArborX tests for Trilinos 14/Kokkos 4 #15391

merged 1 commit into from Jun 20, 2023

Conversation

masterleinad
Copy link
Member

@masterleinad masterleinad commented Jun 20, 2023 •
edited by tamiko

Kokkos 4 enforces that Kokkos::initialize/finalize is called only once. The tests here are calling MPI_InitFinalize which initializes Kokkos and they also initialize Kokkos explicitly. Furthermore, we shouldn't try to initialize Kokkos if it has already been finalized.

In reference to #15383

@masterleinad masterleinad added this to the Release 9.5 milestone Jun 20, 2023
@tamiko tamiko added the Tests label Jun 20, 2023
@tamiko tamiko merged commit 6ae5c84 into dealii:master Jun 20, 2023
14 checks passed
@masterleinad masterleinad deleted the fix_arborx_tests_trilinos14_kokkos4 branch June 21, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@tamiko tamiko tamiko approved these changes

Assignees
No one assigned
Labels
ready to test Reviewed and ready to merge Tests
Projects
None yet
Milestone
Release 9.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @Rombur @tamiko