Testsuite: mpi/hp_cell_weights_* do not compare output for metis variants #15394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we no longer compare output files for this (metis based) test we have to signal an error condition (in this case we expect an exception to be thrown!) with a nonzero exit status.
As we no longer compare output files for this (metis based) test we have to signal an error condition (in this case we expect an exception to be thrown!) with a nonzero exit status.
marcfehling
approved these changes
Jun 20, 2023
Comment on lines
+116
to
+118
| deallog << "Error: we did not throw an exception when we should have" | ||
| << std::endl; | ||
| std::abort(); |
There was a problem hiding this comment.
Can't you just remove the try-catch block and only execute
tria.execute_coarsening_and_refinement();
?
There was a problem hiding this comment.
The logic is reversed. I have to catch the exception thrown in tria.execute_coarsening_and_refinement() and instead signal an error if it doesn't throw.
masterleinad
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partitioning with metis is not stable, so simply suppress output
As we no longer compare output files for these metis based tests we have to signal all error conditions with a nonzero exit status. Which we do now.
In reference to #15383