Move source/matrix_free up in build order #15413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rombur
approved these changes
Jun 21, 2023
masterleinad
approved these changes
Jun 21, 2023
drwells
approved these changes
Jun 21, 2023
bangerth
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with a moderate number of threads, say between 10 and 30, the files taking a long time to compile inside the
source/matrix_freecan lead to a loss of parallelism when invoked towards the end of the build. These were initially added rather recently before the 9.3 release with dc4efca. This PR makes sure that thematrix_freefolder is among the first targets, making sure the long-running tasks get started early enough. (This is formake;ninjalikely does this on its own.)