Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOX: catch std::runtime_error instead of char* for Trilinos 14.2.0 onwards #15450

Merged
merged 3 commits into from Jun 23, 2023
Merged

NOX: catch std::runtime_error instead of char* for Trilinos 14.2.0 onwards #15450

merged 3 commits into from Jun 23, 2023

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 23, 2023

@tamiko tamiko requested a review from bangerth June 23, 2023 05:59
@tamiko tamiko added this to the Release 9.5 milestone Jun 23, 2023
@tamiko
Copy link
Member Author

tamiko commented Jun 23, 2023

/rebuild

@tamiko @kronbichler
Update include/deal.II/trilinos/nox.templates.h
8897fb6 
Co-authored-by: Martin Kronbichler <martin.kronbichler@uni-a.de>
@tamiko @kronbichler
Update include/deal.II/trilinos/nox.templates.h
e9ff803 
Co-authored-by: Martin Kronbichler <martin.kronbichler@uni-a.de>
bangerth
bangerth approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's funny. I wrote the patch for Trilinos that changed the exception type :-)

@bangerth bangerth changed the title NOX: catch std::runtime_error instead of char* for Trilinos 4.2.0 onwards NOX: catch std::runtime_error instead of char* for Trilinos 14.2.0 onwards Jun 23, 2023
@bangerth bangerth merged commit b3a6131 into dealii:master Jun 23, 2023
14 checks passed
@tamiko tamiko deleted the fix_nox_exception branch July 7, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth approved these changes

@kronbichler kronbichler kronbichler approved these changes

Assignees
No one assigned
Labels
Bug ready to test Reviewed and ready to merge
Projects
None yet
Milestone
Release 9.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tamiko @bangerth @kronbichler