Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test distributed_grids/3d_refinement_08: add output variants #15461

Merged
merged 1 commit into from Jun 24, 2023

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 23, 2023

Both tests show consistent but different output, so I guess this is due to
a newer P4est library version.

In reference to #15383

@tamiko tamiko added the Tests label Jun 23, 2023
@tamiko tamiko added this to the Release 9.5 milestone Jun 23, 2023
@bangerth
Copy link
Member

#15461 also addresses one of these test case.

I don't actually think that it has anything to do with p4est. 3d_coarsening_04 compares parallel and non-parallel triangulations, and they both result in the same number of cells but only one of them actually uses p4est. I have a suspicion that the (existing) output file is simply broken, but have no way of checking that.

@tamiko tamiko changed the title Test distributed_grids/3d_{refinement_08,coarsening_04}: add output variants Test distributed_grids/3d_refinement_08: add output variants Jun 24, 2023
@tamiko tamiko force-pushed the fix_distributed_grids_tests branch from 0b085fe to e3eb431 Compare June 24, 2023 01:03
@tamiko
Copy link
Member Author

tamiko commented Jun 24, 2023

@bangerth I have dropped the redundant commit.

@marcfehling marcfehling merged commit c934630 into dealii:master Jun 24, 2023
11 of 14 checks passed
tamiko pushed a commit to tamiko/dealii that referenced this pull request Jun 24, 2023
Test distributed_grids/3d_refinement_08: add output variants
@tamiko tamiko deleted the fix_distributed_grids_tests branch July 7, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants