Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out --help from argv when initializing Kokkos #15465

Merged
merged 3 commits into from Jun 25, 2023

Conversation

bangerth
Copy link
Member

Fixes #15456. Alternative to #15464.

@bangerth bangerth added this to the Release 9.5 milestone Jun 24, 2023
@tamiko
Copy link
Member

tamiko commented Jun 24, 2023

I prefer this version. I think there is little harm in passing argc, argv down to kokkos given the fact that kokkos has a separate --kokkos-* namespace for arguments. For example, the kokkos help message is still available via --kokkos-help.

The problem comes with interpreting non-namespaced arguments such as --help.

@tamiko
Copy link
Member

tamiko commented Jun 25, 2023

I think we have sufficient consensus.

@tamiko tamiko merged commit dc8f0fd into dealii:master Jun 25, 2023
14 checks passed
@kronbichler
Copy link
Member

As expressed in #15456, I agree with this setting. I am not sure if it is the solution we will have long-term, but for now I think this addresses the most pressing issue.

@peterrum
Copy link
Member

I also don't think this is the perfect solution. Working with additional datas as in the rest of the library would probably make more sense. At least --help works again 👍 However, since MPI_InitFinalize is (still) not well documented, we can still changes this while keeping backwards compatibility.

@bangerth bangerth deleted the kokkos branch June 26, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing --help to a deal.II application prints the kokkos help
6 participants