Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: improve testsuite driver performance #15479

Closed
wants to merge 3 commits into from

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 25, 2023

Some preliminary results:

% ctest -R "petsc_step-27.mpirun=2.debug" # first run:
1/2 Test #9807: test_dependency/mpi.petsc_step-27.debug.executable ...   Passed   14.15 sec
2/2 Test #9811: mpi/petsc_step-27.mpirun=2.debug .....................   Passed    3.08 sec
% ctest -R "petsc_step-27.mpirun=2.debug" # rerun:
1/2 Test #9807: test_dependency/mpi.petsc_step-27.debug.executable ...   Passed    0.15 sec
2/2 Test #9811: mpi/petsc_step-27.mpirun=2.debug .....................   Passed    0.14 sec

As compared to a baseline test with make:

% ctest -R "petsc_step-27.mpirun=2.debug" # first run
1/2 Test #9807: test_dependency/mpi.petsc_step-27.debug.executable ...   Passed   16.38 sec
2/2 Test #9811: mpi/petsc_step-27.mpirun=2.debug .....................   Passed    5.42 sec
% ctest -R "petsc_step-27.mpirun=2.debug" # rerun
1/2 Test #9807: test_dependency/mpi.petsc_step-27.debug.executable ...   Passed    2.36 sec
2/2 Test #9811: mpi/petsc_step-27.mpirun=2.debug .....................   Passed    2.33 sec

@tamiko tamiko added this to the Release 9.6 milestone Jun 25, 2023
@tamiko tamiko marked this pull request as draft June 25, 2023 07:14
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand what you're doing here, but got a couple of suggestions.

tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Show resolved Hide resolved
@tamiko
Copy link
Member Author

tamiko commented Jun 26, 2023

@bangerth
This is a very preliminary version of some more massive rewriting effort.

My goal is to significantly reduce the overhead introduced by make in the testsuite. For example, for some tests make might contribute to north of 25% of the total runtime of the test.

@tamiko
Copy link
Member Author

tamiko commented Jan 26, 2024

New PR incoming.

@tamiko tamiko closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants