MatrixFree inverse mass matrix: Make tests more robust #15486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two tests recently introduced by @bugrahantemur more robust by making the dyadic tensor more diagonally dominant with similar size of the entries (make entries spread around 5, rather than multiplying random numbers between 0.01 and 0.1 by 100). This should address failures like https://cdash.dealii.org/test/1003848 that fail because GMRES without precondition does not converge in 1000 iterations (roundoff errors are significant).
While there, also remove a refinement step that does not execute,
if (cell->center().norm() < 1e-8)will evaluate to false as soon as the grid for(-1, 1)is refined at least once.