[9.5] CMake: remove VTK configure option #15515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
changed the title
Closed
|
There are a few other places where we use this feature:
I'd prefer to remove all of it in addition to the CMake configuration. |
|
@drwells Sure. Let me update the pull request. |
Our CMake configure for VTK isn't quite prime-time ready. Given the fact that we currently only support a very minimal infrastructure, let's just remove the configure option for the release. Acked-by: Luca Heltai <luca.heltai@sissa.it>
|
@drwells updated! /rebuild |
kronbichler
approved these changes
Jun 29, 2023
|
I'm not quite sure why osx builds are failing on jenkins. It looks like we don't set cxx standard properly. I'm going to ignore that for the moment. |
luca-heltai
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CMake configure for VTK isn't quite prime-time ready. Given the fact
that we currently only support a very minimal infrastructure, let's just
remove the configure option for the release.
In reference to #15383
@luca-heltai ping