Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.5] CMake: remove taskflow macros from config.h.in #15518

Merged
merged 1 commit into from Jun 29, 2023
Merged

[9.5] CMake: remove taskflow macros from config.h.in #15518

merged 1 commit into from Jun 29, 2023

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 28, 2023 •
edited

Let us play save and remove the DEAL_II_WITH_TASKFLOW macro from config.h.in so that taskflow cannot be configured "by accident" (i.e., by accidentally enabling this variable and setting it in cache).

Thanks to @kronbichler for pointing this out.

In reference to #15383
In reference to #15511

@tamiko tamiko added this to the Release 9.5 milestone Jun 28, 2023
@tamiko tamiko mentioned this pull request Jun 28, 2023
Closed
@kronbichler kronbichler merged commit 2190366 into dealii:dealii-9.5 Jun 29, 2023
11 of 14 checks passed
@tamiko tamiko deleted the remove_taskflow_2 branch July 7, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwells drwells drwells approved these changes

@kronbichler kronbichler kronbichler approved these changes

Assignees
No one assigned
Labels
Build system External libraries
Projects
None yet
Milestone
Release 9.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tamiko @drwells @kronbichler