Remove deprecations in consensus algorithms #15529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Jun 30, 2023
|
I assume you found all of these places by looking at the deprecations before we converted the early-deprecated to deprecated in #15507? |
|
The "tidy" check fails with this: /home/runner/work/dealii/dealii/include/deal.II/base/mpi_consensus_algorithms.h:1418:43: error: use '= default' to define a trivial default constructor [modernize-use-equals-default,-warnings-as-errors] Can you address this as well? If you rebase, the failing OSX check will also go away. |
Yes, I tried my best. |
masterleinad
force-pushed
the
remove_deprecated_consensus_algorithms
branch
from
1dfc553
to
15310df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in #13272, and #13769.