Fix SolutionTransfer to properly compress() vectors. #15577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bangerth note that recent versions of PETSc compiled in debug mode will actually complain about the unassembled (ie. VecSetValues called without later assembly) status of the vector. I suggest to use it in CI to catch this and other kind of possible problems , since this is what a debug version does. |
|
@tamiko Do we use debug or release versions of PETSc in our CI? |
kronbichler
approved these changes
Jul 2, 2023
|
Tests cleanly. |
masterleinad
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SolutionTransfer class writes into output vectors, but does
not call compress() on them. This is of no consequence for deal.II
vectors for which this class is mostly used (in contrast to the
parallel::distributed::SolutionTransfer class), but leads to awkward
downstream failures with, for example, PETSc vectors.
Fixes #15574.