lac/trilinos_tpetra...h: Fix compilation on Ubuntu 20.04 #15612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
reviewed
Jul 3, 2023
Comment on lines
+135
to
+144
| /* | ||
| * For Trilinos older than 13.2 we would normally have to call | ||
| * vector.template sync<Kokkos::HostSpace>() at this place in order | ||
| * to sync between memory spaces. This is necessary for GPU support. | ||
| * Unfortunately, we are in a const context here and cannot call to | ||
| * sync() (which is a non-const member function). | ||
| * | ||
| * Let us choose to simply ignore this problem for such an old | ||
| * Trilinos version. | ||
| */ |
There was a problem hiding this comment.
I think this is OK but we could also check via need_sync_host(https://docs.trilinos.org/dev/packages/tpetra/doc/html/classTpetra_1_1MultiVector.html#a5af96c2c9c0212e16b88a97d3ab7a284) if we are running into issues.
There was a problem hiding this comment.
You can always do a const cast. As long as the function is "semantically const", that should be ok.
There was a problem hiding this comment.
We discussed and agreed to keep this PR as is for the time being. We can revisit if someone ever ends up using an old Trilinos version with GPUs.
drwells
reviewed
Jul 3, 2023
drwells
approved these changes
Jul 3, 2023
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part to really: Fixes #15580