KINSOL: allow for custom setup #15677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebproell
commented
Jul 7, 2023
peterrum
approved these changes
Jul 7, 2023
bangerth
reviewed
Jul 7, 2023
include/deal.II/sundials/kinsol.h
Outdated
| * | ||
| * @code | ||
| * ode.custom_setup = [&](void *arkode_mem) { | ||
| * KINSetErrFile(arkode_mem, errfile); |
There was a problem hiding this comment.
Can you also show the code to set up errfile?
Separately, is arkode_mem really a void * or does ARKode use an actual type for that?
There was a problem hiding this comment.
Internally they likely use a custom type for that but to users this type is always erased. When calling KINCreate we are only handed a void* and are supposed to hand it back to all "member functions". It's a C Library 🤷
|
/rebuild |
sebproell
force-pushed
the
kinsol-custom-setup
branch
from
d2a2d68
to
32a98ad
Compare
bangerth
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is already available in ARKODE and is now introduced equivalently to KINSOL. I modified test
kinsol_05to test this functionality.