Guard NOX support in include/deal.II/numerics/nonlinear.h #15704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Jul 10, 2023
kronbichler
approved these changes
Jul 10, 2023
bangerth
approved these changes
Jul 10, 2023
|
Our instructions did not recommend to build Trilinos with NOX. I have a patch ready I'll submit later today to add that recommendation. I think this patch should also go on the 9.5 branch. Want to submit a PR to that end? |
|
It is actually not a big deal because this only triggers if someone includes this new header. |
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidywas complaining thatNOXcould not be found but II could still compile the library without these changes.