Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: remove support for ctest_memcheck() and run_memorycheck.cmake #15716

Merged
merged 1 commit into from Jul 11, 2023
Merged

CMake: remove support for ctest_memcheck() and run_memorycheck.cmake #15716

merged 1 commit into from Jul 11, 2023

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jul 11, 2023

Instead of using valgrind it is much better to use compiler sanitizers such as "-fsanitize=address,undefined,leak" with clang.

@tamiko
CMake: remove support for ctest_memcheck() and run_memorycheck.cmake
5bc1278 
Instead of using valgrind it is much better to use compiler sanitizers
such as "-fsanitize=address,undefined,leak" with clang.
@tamiko
Copy link
Member Author

tamiko commented Jul 11, 2023

/rebuild

@tamiko
Copy link
Member Author

tamiko commented Jul 11, 2023

@masterleinad ping In light of -fsanitize=address,leak I think it is time to retire this old and rarely used testsuite variant.

@tjhei tjhei merged commit f7f3472 into dealii:master Jul 11, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjhei tjhei tjhei approved these changes

@masterleinad masterleinad masterleinad approved these changes

@kronbichler kronbichler kronbichler approved these changes

Assignees
No one assigned
Labels
Build system ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tamiko @tjhei @masterleinad @kronbichler