Add missing changelog entry about the improvement to step-68 #15744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Jul 14, 2023
No worries. Both are fine with me. It is just that it was asked of me, hence me making it :). |
kronbichler
reviewed
Jul 14, 2023
| @@ -0,0 +1,3 @@ | |||
| Improvement: Step-68 now uses the FEPointEvaluation to calculate the particle velocity from the velocity solution instead of manually interpolating at the particle location. | |||
| <br> | |||
| (Bruno Blais, 2023/07/0) | |||
There was a problem hiding this comment.
Do you want to set the right date?
Suggested change
| (Bruno Blais, 2023/07/0) | |
| (Bruno Blais, 2023/07/07) |
Also, please break the first line at 80 characters.
|
I disagree that we don't need these entries. They are useful to show our users what all we have done, and we also use them to write the release papers and release announcements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @bangerth , this adds a changelog entry to the improvement made to step-68 :)
Sorry about that.