Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix up some std::is_same<...> places. #15748

Merged
merged 1 commit into from Jul 16, 2023
Merged

Conversation

bangerth
Copy link
Member

I was getting some weird error messages about undefined symbols. I did not try to track this down in detail, but I believe that what happened is that the function declaration used std::is_same_v, but the definition continues to use std::is_same. If this is just a namespace-level function, then the compiler will simply treat these as different overloads of the same name -- leading to linker errors.

So I simply went through the entire library and replaced all occurrences of std::same_as by std::same_as_v (except for one place where we used the type, not ::value). The places I had missed previously are the ones where std::is_same appears on a different line than ::value -- hard to catch by script.

@tamiko tamiko merged commit db38f30 into dealii:master Jul 16, 2023
15 checks passed
@bangerth bangerth deleted the same-as branch July 16, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants