tweak PETSc tests #15767
Merged
tweak PETSc tests #15767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jul 19, 2023
Comment on lines
+384
to
+389
| // This test requires PETSc to be configured with the option | ||
| // "--with-threadsafety" in case of debug builds of PETSc. | ||
| // For optimized builds, the above option is needed only in case | ||
| // users want PETSc to produce useful logs with "-log_view" runtime | ||
| // option | ||
| #if !defined(PETSC_USE_DEBUG) || defined(PETSC_HAVE_THREADSAFETY) |
There was a problem hiding this comment.
This will make the test fail if that flag is not set (because the output is different), right? If so, I would prefer to just abort the test.
What happens if PETSC_USE_DEBUG is defined?
There was a problem hiding this comment.
The test won't fail since it will print zero as error
There was a problem hiding this comment.
With PETSC_USE_DEBUG petsc uses additional non threadsafe structures to track entry and exit points of functions
There was a problem hiding this comment.
Oh, I see now -- the correct output is 0. Yes, this will work then.
Is PETSC_USE_DEBUG the default?
|
/rebuild |
luca-heltai
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.