Config.h.in: use PETSc/SLEPc macros to determine PETSc/SLEPc version #15770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use code in the development version
|
/rebuild |
bangerth
reviewed
Jul 21, 2023
Comment on lines
+397
to
+402
| #ifdef DEAL_II_WITH_PETSC | ||
| # define DEAL_II_PETSC_VERSION_LT(major,minor,subminor) \ | ||
| PETSC_VERSION_LT(major,minor,subminor) | ||
| # define DEAL_II_PETSC_VERSION_GTE(major,minor,subminor) \ | ||
| PETSC_VERSION_GE(major,minor,subminor) | ||
| #endif |
There was a problem hiding this comment.
Have these been around for a long time? I believe that they didn't exist when I first wrote the interfaces for PETSc, but that was in 2004/2005. We've long not supported such old versions any more.
There was a problem hiding this comment.
The only difference is that the PETSc macros also test for PETSC_VERSION_RELEASE which is 1 for a release, 0 for any other commit which is not a tag. For example PETSC_VERSION_LT will always expand to 0 when developing, while PETSC_VERSION_GE will always expand to 1 in the same case.
bangerth
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use code in the development version