Adjust expectations in a GridTools::get_coarse_mesh_description(). #15802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chipping away at the test failures in #15689:
GridTools::get_coarse_mesh_description()makes the assumption that the vertices of level 0 of the mesh are contiguous, starting at index 0. That's currently true: A mesh has to be created with level 0, and so these vertices are the first ones that exist and never removed or renumbered. But #15689 wants to renumber them, and I'm taking this as an opportunity to remove this assumption from the function. At some point in the function, we have to shrink the vertices array to just the ones we really care; currently, this happens at the very top in a hand-rolled loop, but we can also do that once everything is set up, using anotherGridToolsfunction that already exists for exactly this purpose:GridTools::delete_unused_vertices().