Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGTwoLevelTransferNonNested: enable simplex #15820

Merged
merged 1 commit into from Aug 24, 2023
Merged

MGTwoLevelTransferNonNested: enable simplex #15820

merged 1 commit into from Aug 24, 2023

Conversation

peterrum
Copy link
Member

@peterrum peterrum commented Aug 2, 2023 •
edited

depends on #15843

kronbichler
kronbichler reviewed Aug 5, 2023
View reviewed changes
Copy link
Member

@kronbichler kronbichler left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this PR is completely finished ('No description provided' is a good summary of what I miss). I marked some internal changes that should only be a temporary solution, as data structures get added that should probably not. It seems to me as this PR is following the path of least resistance, but I would like to see a strategy where this should go before I can approve it.

include/deal.II/matrix_free/fe_point_evaluation.h Outdated Show resolved Hide resolved
include/deal.II/matrix_free/fe_point_evaluation.h Outdated Show resolved Hide resolved
include/deal.II/multigrid/mg_transfer_global_coarsening.templates.h Outdated Show resolved Hide resolved
include/deal.II/multigrid/mg_transfer_global_coarsening.templates.h Outdated Show resolved Hide resolved
include/deal.II/non_matching/mapping_info.h Outdated Show resolved Hide resolved
@peterrum peterrum mentioned this pull request Aug 5, 2023
Merged
@peterrum
Copy link
Member Author

peterrum commented Aug 5, 2023

I do not think this PR is completely finished ('No description provided' is a good summary of what I miss). I marked some internal changes that should only be a temporary solution, as data structures get added that should probably not. It seems to me as this PR is following the path of least resistance, but I would like to see a strategy where this should go before I can approve it.

I have created a new PR for the FEPointEvaluation-/MappingInfo-related changes -> #15843.

@peterrum peterrum force-pushed the non_nested_transfer_simplex branch from 186f3ee to 3bd74d7 Compare August 5, 2023 12:55
@peterrum peterrum force-pushed the non_nested_transfer_simplex branch 3 times, most recently from 2cbabd2 to f27bca0 Compare August 23, 2023 16:09
@peterrum
Copy link
Member Author

@kronbichler I have rebased this PR and removed the merge conflicts!

kronbichler
kronbichler approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if you resolve the merge conflict.

@peterrum peterrum merged commit 80a9f98 into dealii:master Aug 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kronbichler kronbichler kronbichler approved these changes

Assignees
No one assigned
Labels
Multigrid ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterrum @kronbichler