Fix issue when compiling with HIP #15862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
reviewed
Aug 8, 2023
include/deal.II/base/numbers.h
Outdated
| @@ -41,7 +41,7 @@ | |||
| // This is problematic when calling non-constexpr functions in constexpr | |||
| // functions. Hence, we need a way to annotate functions explicitly as | |||
| // host-only. | |||
| #if defined(__clang__) && defined(__CUDA__) | |||
| #if defined(__clang__) && defined(__CUDA__) || defined(KOKKOS_ENABLE_HIP) | |||
There was a problem hiding this comment.
I always forget if && has precedence over ||.
Suggested change
| #if defined(__clang__) && defined(__CUDA__) || defined(KOKKOS_ENABLE_HIP) | |
| #if (defined(__clang__) && defined(__CUDA__)) || defined(KOKKOS_ENABLE_HIP) |
Also, the above command also doesn't match anymore. Maybe, say something like
// clang++ assumes that all constexpr functions are __host__ __device__ when `Kokkos` was configured with `HIP` or `CUDA` support. [...]
There was a problem hiding this comment.
I always forget if && has precedence over ||
It doesn't matter since all the HIP compiler are clang based
masterleinad
approved these changes
Aug 8, 2023
|
/rebuild |
marcfehling
approved these changes
Aug 9, 2023
Co-authored-by: Marc Fehling <mafehling.git@gmail.com>
marcfehling
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I can compile and run deal.II on Frontier.