Use iterative implementation for Utilities::pow to support Intel GPUs #15868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
approved these changes
Aug 11, 2023
blaisb
approved these changes
Aug 11, 2023
bangerth
reviewed
Aug 15, 2023
Comment on lines
+482
to
+484
| // The "exponentiation by squaring" algorithm used below has to be expressed | ||
| // in an iterative version since SYCL doesn't allow recursive functions used | ||
| // in device code. |
There was a problem hiding this comment.
I thought that restrictions on the use of recursion had been lifted sometime during the transition from Fortran 4 to C. How disappointing to see that this has been reintroduced in 2023 :-(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need
Utilities::powto have an iterative implementation for compilingstep-64forIntelGPUs sinceSYCLdoesn't allow recursive functions in device code.