Use a relative tolerance. #15890
Merged
Use a relative tolerance. #15890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
approved these changes
Aug 17, 2023
source/grid/tria_description.cc
Outdated
| @@ -268,21 +268,26 @@ namespace TriangulationDescription | |||
| { | |||
| std::sort(this->coarse_cell_vertices.begin(), | |||
| this->coarse_cell_vertices.end(), | |||
| [](const auto &a, const auto &b) { | |||
| [](const std::pair<unsigned int, Point<spacedim>> &a, | |||
| std::pair<unsigned int, Point<spacedim>> & b) { | |||
There was a problem hiding this comment.
Suggested change
| std::pair<unsigned int, Point<spacedim>> & b) { | |
| const std::pair<unsigned int, Point<spacedim>> &b) { |
This used to be const before.
masterleinad
approved these changes
Aug 17, 2023
|
Good point about the |
marcfehling
approved these changes
Aug 18, 2023
kronbichler
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debugging something unrelated, I had to look at a piece of code that compares two vertex locations for equality. The existing code uses an absolute tolerance, but that isn't going to work well when using meshes at atomic or cosmic length scales. Use a relative tolerance instead.
While there, I also made the types used in this lambda function explicit.