Standardize on 'const X' instead of 'X const'. #15908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
approved these changes
Aug 22, 2023
masterleinad
approved these changes
Aug 22, 2023
|
Wait, you didn't even wait for the CI checks? :-) |
tamiko
reviewed
Aug 22, 2023
| @@ -1813,7 +1813,7 @@ namespace FETools | |||
| // sufficiently large so that there | |||
| // are more than about 5000 | |||
| // operations in the inner loop | |||
| // (which is basically const * n^2 | |||
| // (which is const basically * n^2 | |||
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #15903. I think this catches a good share of the non-whitespace changes in #15903. There are a few of the form
X constwhereXis a template type that I cannot easily catch with a regex -- but this is better than nothing I figure.