Tensor polynomials: Remove nonsensical comments #15915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #15913, I realized that all classes derived from
TensorPolynomialsBase
refer to somecompute_value
,compute_grad
,compute_grad_grad
functions that are not even present in these classes. I guess this is a copy-paste effect from the scalar tensor product polynomial classdealii/include/deal.II/base/tensor_product_polynomials.h
Lines 126 to 129 in e3b4ff4
dealii/include/deal.II/base/tensor_product_polynomials.h
Lines 151 to 152 in e3b4ff4
PolynomialsRaviartThomas
to get the matrix-free initialization reasonably fast (the current method has a quadratic complexity inShapeInfo::reinit()
because it evaluates the complete basis for every basis function we request viaFE_PolyTensor::shape_value_component()
), that is a wrong assumption, and it is in fact better to work towards #9655.