Add Functions::RayleighKotheVortex #15932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
requested changes
Aug 27, 2023
source/base/function_lib.cc
Outdated
|
|
||
| const double px = numbers::PI * point(0); | ||
| const double py = numbers::PI * point(1); | ||
| const double pt = numbers::PI / T * t; |
There was a problem hiding this comment.
Not sure if that's the best variable name. pt for me mentally translates to point... but maybe that's just me :)
There was a problem hiding this comment.
I am fine with the names.
There was a problem hiding this comment.
Maybe
Suggested change
| const double pt = numbers::PI / T * t; | |
| const double pi_t = numbers::PI / T * t; |
and similarly above?
There was a problem hiding this comment.
@masterleinad I went with your name suggestion. Thanks 👍
| @@ -278,7 +236,7 @@ namespace Step68 | |||
| MappingQ1<dim> mapping; | |||
| LinearAlgebra::distributed::Vector<double> velocity_field; | |||
|
|
|||
| Vortex<dim> velocity; | |||
| Functions::RayleighKotheVortex<dim> velocity; | |||
There was a problem hiding this comment.
Can you also make the same change in the performance benchmark while we are at it?
:)
peterrum
force-pushed
the
RayleighKotheVortex
branch
from
28e3999
to
4c73fcd
Compare
peterrum
force-pushed
the
RayleighKotheVortex
branch
from
4c73fcd
to
d9805d0
Compare
|
/rebuild |
blaisb
approved these changes
Aug 30, 2023
| /** | ||
| * A class that represents a time-dependent function object for a | ||
| * Rayleigh--Kothe vortex vector field. This is generally used as | ||
| * flow pattern in complex test cases for interface tracking methods |
There was a problem hiding this comment.
Suggested change
| * flow pattern in complex test cases for interface tracking methods | |
| * as flow pattern in complex test cases for interface tracking methods |
?
There was a problem hiding this comment.
The line above contains the as.
source/base/function_lib.cc
Outdated
|
|
||
| const double px = numbers::PI * point(0); | ||
| const double py = numbers::PI * point(1); | ||
| const double pt = numbers::PI / T * t; |
There was a problem hiding this comment.
Maybe
Suggested change
| const double pt = numbers::PI / T * t; | |
| const double pi_t = numbers::PI / T * t; |
and similarly above?
peterrum
force-pushed
the
RayleighKotheVortex
branch
from
d9805d0
to
7a40b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.