Avoid switches in cuda_tensor_product_kernels.h #15937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
avoid_swicthes_kokkos_matrix_free
branch
2 times, most recently
from
4f37507
to
c6df6b9
Compare
masterleinad
force-pushed
the
avoid_swicthes_kokkos_matrix_free
branch
from
c6df6b9
to
d4d69c1
Compare
drwells
approved these changes
Aug 28, 2023
kronbichler
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code more concise, adds more error messages, and might compile faster by avoiding some instantiations due to using
if constexpr.