Add step-87: Tutorial on RemotePointEvaluation #15961
Conversation
examples/step-87/step-87.cc
Outdated
|
|
||
| // We output the requested points together with the corresponding | ||
| // evaluated solution to a CSV file. | ||
| std::cout << " - writing csv file" << std::endl; |
There was a problem hiding this comment.
Is the underlying goal here to illustrate that there many ways to achieve the same thing, or do you wish to demonstrate that some approaches are more efficient / less time consuming?
I am not sure I understand the full motivation for showing three different ways to achieve the same purpose. Generally, my understanding is that it is a bad thing when you have three ways of doing the same things, it's confusing for a new reader.
|
@blaisb @kronbichler first of all, thank you very much for taking the time to review this tutorial. In my opinion, your comments are very helpful in improving the readability of the tutorial and also the practical applicability of the code sections. So far, I have addressed the minor points of your reviews. I am at a conference for the next few days and will work on the major points early next week. |
We should be the one thanking you for taking the time to contribute such a cool example. This will be helping a lot of people in the long term. I'll finish reviewing the .cc file today and this way when you address the comments, i'll be ready for a second round of review. |
There was a problem hiding this comment.
A few last comments, nothing major. @mschreter just ping me when you want another review I'll be glad to do it
|
@blaisb @kronbichler we addressed your suggestions and would be ready for a second round of reviews :-). We extracted the changes not specific to this tutorial and related to RemotePointEvaluation in two separate PRs #15995 and #15996. I'll rebase once we are finished with the review. |
|
I accidentally closed this PR when rebasing and fixing merge conflicts. The new PR is #16072. |
This PR proposes to introduce a new tutorial (PDF) on the usage of advanced point evaluation functionalities based on
Utilities::MPI::RemotePointEvaluation. The motivation for this work comes from our ongoing research on two-phase flows with phase change, where we use those functionalities.We (@peterrum and me) are looking forward to hearing your thoughts about it!