FE_PolyTensor: Only request dof_sign_change if necessary #15963
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I saw with
FE_RaviartThomasNodal
on another check (PR to be opened soon):FEValues
requesting only mapping information but initialized with elements derived fromFE_PolyTensor
would previously run into an assertion on unstructured 2d meshes. The fix is to only use the helper function in the case that uses thedof_sign_change
further down infill_fe_values
.