Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about deprecated implicit conversion. #16000

Merged
merged 3 commits into from Sep 18, 2023

Conversation

marcfehling
Copy link
Member

@marcfehling marcfehling commented Sep 18, 2023

This should take care of the warning introduced in #15415 (comment).

@kronbichler
Copy link
Member

There is one additional error, now at the linker stage (showing that the error in #15415 was indeed not just spurious):

 /usr/bin/ld: ../lib/libdeal_II.g.so.9.6.0-pre: undefined reference to `void dealii::internal::hermite_hierarchic_to_lexicographic_numbering<0>(unsigned int, std::vector<unsigned int, std::allocator<unsigned int> >&)'
/usr/bin/ld: ../lib/libdeal_II.g.so.9.6.0-pre: undefined reference to `dealii::FiniteElementData<0>::FiniteElementData(std::vector<unsigned int, std::allocator<unsigned int> > const&, unsigned int, unsigned int, dealii::FiniteElementData<0>::Conformity, dealii::BlockIndices const&)'

@peterrum
Copy link
Member

I think the undefined references should be fixed now. There is some recursive template calling which is actually terminates with dim=1.

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
@peterrum peterrum merged commit 43efdb9 into dealii:master Sep 18, 2023
15 checks passed
@marcfehling marcfehling deleted the hermite branch September 18, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants