Fix Tpetra 64 bit global ordinate errors #16005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Since trilinos/Trilinos@67f5151 (12.18.1) Tpetra is always instantiated for long long int as global ordinal type by default.
We should be careful with casting between pointers of type signed_global_dof_index* and global_dof_index since they are now differ by more than signedness.
jpthiele
force-pushed
the
jpt-fix-64bit-tpetra-type
branch
from
31bf623
to
4a57736
Compare
masterleinad
reviewed
Oct 1, 2023
jpthiele
force-pushed
the
jpt-fix-64bit-tpetra-type
branch
from
4a57736
to
4b2e084
Compare
jpthiele
force-pushed
the
jpt-fix-64bit-tpetra-type
branch
from
4b2e084
to
34d4428
Compare
|
Updated to current master, should fix previous intel compiler action error. |
masterleinad
approved these changes
Oct 4, 2023
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tpetra requires long long as global ordinate type, which does not always match with std::int64_t.
Therefore, configure stage fails with default Tpetra settings.
Changed signed_global_index_type in types.h to reflect this too. Also added hopefully helpful CMake messages
in case the Tpetra check fails.
If it is global index related it will offer two ways to make Tpetra usable in deal.II.